Skip to content

test(data): Gen2 data customize auth doc example testing #3705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Conversation

lawmicha
Copy link
Contributor

@lawmicha lawmicha commented May 16, 2024

Issue #

Description

This PR builds ontop of #3699 and keeps adding more schemas to test the docs. The docs PR is at aws-amplify/docs#7604

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lawmicha lawmicha requested a review from a team as a code owner May 16, 2024 19:25
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.59%. Comparing base (c130105) to head (93e9e43).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3705      +/-   ##
==========================================
- Coverage   68.51%   67.59%   -0.92%     
==========================================
  Files        1089     1016      -73     
  Lines       37651    34253    -3398     
==========================================
- Hits        25795    23152    -2643     
+ Misses      11856    11101     -755     
Flag Coverage Δ
API_plugin_unit_test 68.97% <ø> (ø)
AWSPluginsCore 65.81% <ø> (ø)
Amplify 48.17% <ø> (+0.01%) ⬆️
Analytics_plugin_unit_test 84.52% <ø> (ø)
Auth_plugin_unit_test 79.34% <ø> (+0.01%) ⬆️
DataStore_plugin_unit_test 81.39% <ø> (-0.57%) ⬇️
Geo_plugin_unit_test 72.00% <ø> (ø)
Logging_plugin_unit_test 62.87% <ø> (ø)
Predictions_plugin_unit_test 37.32% <ø> (ø)
PushNotifications_plugin_unit_test 86.21% <ø> (ø)
Storage_plugin_unit_test ?
unit_tests 67.59% <ø> (-0.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from docs.data to main June 3, 2024 15:34
thisisabhash
thisisabhash previously approved these changes Jun 3, 2024
@lawmicha lawmicha merged commit d6583e6 into main Jun 3, 2024
78 of 79 checks passed
@lawmicha lawmicha deleted the docs.data.2 branch June 3, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants