added rekognition customlabels feature to amplify predictions category #7328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates on this? |
siegerts
added
the
first-time-contributor
|
Apologizes on not following up on this pull request sooner @rpostulart. We are going to take a look at this and see if this is something we would like to have within the library. @elorzafe or @wlee221 can either of you take a look and see if we need to do a design review for this internally? |
manueliglesias
force-pushed
the
main
branch
from
5b68474 to
66bfe31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
Currently AWS Amplify predictions category is only supporting standard labels from Rekognition. While with custom labels there is a whole new spectrum of Machine Learning that we can add to our client applications. In this change I added the feature to support custom label requests from predictions identify.
Description of changes:
I have made a new types for customLabels input and output.
There is a check added that when there is a request with the param customlabel that the function identifyCustomLabels is called. This function is an abstraction of identifyLabels.
_Unit test:
I am not an expert in creating unit tests. I tried to create a few, but therefor the model needs to run otherwise the test fails. So there is still some work to do to mock this service.
_Repo:
here is a react app repo to test the app. Replace the arn with a model arn that you create.
https://github.com/rpostulart/customlabelsApp
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.