Skip to content

refactor(api-rest): allow for body in delete request #14420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PatrickBichiou
Copy link

Description of changes

In the api-rest/index.ts file i change the type of the delete operation to not omit the 'body' attribute. With this change the type of delete allows for an body.
I am not really sure if this is the only changed needed to use body on delete request for rest-api. Maybe some of the amplify team will check on this and provide some guidance if any other changes are necessary.

Issue #, if available

12844

Description of how you validated changes

  • add body in type as for the other types of http methods like put and post.
  • run the yarn test suite

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@PatrickBichiou PatrickBichiou requested a review from a team as a code owner June 6, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant