Skip to content

feat(api-graphql): Add affected items in the errors object #11200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Bhavika-Gianey
Copy link

Description of changes

Adding affected items when a relationship is deleted while querying for the data. The code takes the initial query data when non-null entities are encountered, generates a new query where all the entities will be present by returning only the id's from the query, and then compares the new response with the previous response to check for null entities. The respected null entities are then pushed back in the response.items array.

Issue #, if available

aws-amplify/amplify-category-api#3233

Description of how you validated changes

I checked the query with the schema table the customer was facing and other tables where non-nullable error messages could be shown and then compared the queries with and without the null returned attributes.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Bhavika-Gianey Bhavika-Gianey requested a review from a team as a code owner April 7, 2023 10:25
@tannerabread tannerabread added first-time-contributor The contribution is the first for this user in the repo external-contributor labels Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor first-time-contributor The contribution is the first for this user in the repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants