Skip to content

feat(predictions):adds ssml support to polly integration #10007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elvinrowe
Copy link

Description of changes

  • Adds optional textType property to TextToSpeechInput interface that can be set to either 'text' or 'ssml'.
  • Updated the SynthesizeSpeech call so the TextType can be set by the textType property. TextType defaults to 'text' if textType property is undefined maintaining current functionality.

Issue #, if available

Description of how you validated changes

  • Ran change through a sample app

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

Merging #10007 (c6d02f4) into main (eb73ad7) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #10007      +/-   ##
==========================================
- Coverage   83.62%   83.61%   -0.02%     
==========================================
  Files         253      253              
  Lines       18261    18262       +1     
  Branches     3918     3919       +1     
==========================================
- Hits        15271    15270       -1     
- Misses       2898     2900       +2     
  Partials       92       92              
Impacted Files Coverage Δ
packages/predictions/src/types/Predictions.ts 100.00% <ø> (ø)
packages/core/src/Platform/version.ts 100.00% <100.00%> (ø)
...rc/Providers/AmazonAIConvertPredictionsProvider.ts 83.24% <100.00%> (+0.08%) ⬆️
...kages/amazon-cognito-identity-js/src/BigInteger.js 89.31% <0.00%> (-0.41%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@siegerts siegerts added the first-time-contributor The contribution is the first for this user in the repo label Jun 24, 2022
@manueliglesias manueliglesias requested a review from a team as a code owner September 30, 2022 21:21
@nadetastic nadetastic linked an issue Jan 27, 2023 that may be closed by this pull request
@cwomack cwomack added the Predictions Related to Predictions category label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor first-time-contributor The contribution is the first for this user in the repo Predictions Related to Predictions category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSML support for Polly feature in Predictions
4 participants