fix(sigv4): Convert empty query parameters to null #6082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekjotmultani
approved these changes
Mar 19, 2025
tyllark
added a commit
that referenced
this pull request
May 15, 2025
tyllark
added a commit
that referenced
this pull request
May 28, 2025
tyllark
added a commit
that referenced
this pull request
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#6008
Description of changes:
Web builds send an OPTions request to verify CORS compatibility with the URL and a 404 can be returned if the URL contains unexpected query Parameters. URI.toString() appends a "?" to the URL for an empty query parameter map and we are currently setting null a query parameter to an empty map.
This fix converts empty query parameters to null if it empty to prevent the URL from unintentionally having a "?" appended.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.