-
Notifications
You must be signed in to change notification settings - Fork 260
fix(secure_storage): Add plugin platform entry. #5178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
// Required to register the plugin on windows and linux platforms. | ||
// https://docs.flutter.dev/packages-and-plugins/developing-packages#plugin-platforms | ||
static void registerWith() {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this can be a no-op? There isn't a instance from the current impl to map here.
plugin: | ||
platforms: | ||
linux: | ||
default_package: amplify_secure_storage_dart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default_package
would typically refer to another package. This references itself. Is that something flutter docs suggest doing?
What I am seeing in the docs is to use dartPluginClass
default_package: amplify_secure_storage_dart | |
dartPluginClass: AmplifySecureStorageDart |
You will also have to add a registerWith()
method to AmplifySecureStorageDart I believe. This is based on https://docs.flutter.dev/packages-and-plugins/developing-packages#dart-only-platform-implementations
d246d16
to
f6b49e8
Compare
Issue #, if available:
#5165
Description of changes:
Followed Flutter doc guidance to specify platform specific entry points for the Secure Storage plugin. This resolves the build errors from Flutter Master channel:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.