Deprecated: feat(storage): add delimiter support to list API #5110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hahnandrew
requested review from
Jordan-Nelson,
khatruong2009,
Equartey,
NikaHsn,
tyllark and
ukhan-amazon
hahnandrew
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated, see new pr
Description of changes:
This change will enable delimiter support by passing aDelimiteroption in the underlyingListObjectsV2API.Main changes to list API as specified:- addSubpathStrategyclass- addSubpathStrategytoStorageListOptionsas member- add@Deprecateddecorators toS3ListPluginOptions.excludeSubPaths,S3ListPluginOptions.delimiter, andS3ListMetadata.subPaths- addexcludedSubpaths: List<String>toStorageListResult- add unit and integration testsThis is a parent PR. see implementation and unit & integration tests hotlinked splitsBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.