Feat: fetchCurrentDevice API Implementation #5075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khatruong2009
approved these changes
Jun 25, 2024
Equartey
reviewed
Jun 27, 2024
packages/auth/amplify_auth_cognito_dart/lib/src/auth_plugin_impl.dart
Outdated
Show resolved
Hide resolved
Comment on lines
+1029
to
+1032
| attributes: { | ||
| for (final attribute in attributes) | ||
| attribute.name: attribute.value ?? '', | ||
| }, |
There was a problem hiding this comment.
Q: Does this need a for loop? Does attributes have other properties?
Suggested change
| attributes: { | |
| for (final attribute in attributes) | |
| attribute.name: attribute.value ?? '', | |
| }, | |
| attributes: attributes, |
There was a problem hiding this comment.
Q: Does this need a for loop?
Yes, it's for type conversion. At first glance it looks redundant, but the loop achieves two important things - converting null values to an empty string, and converting a BuiltList to Map
Note that attributes: attributes is type invalid. CognitoDevice types its attributes as map<string, string>, while the attributes from the getDeviceResponse.device (smithy-generatively) types its attributes as BuiltList<AttributeType>?.
Does
attributeshave other properties?
There was a problem hiding this comment.
Makes sense, thanks for adding that context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Implemented
fetchCurrentDeviceAPIBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.