chore(datastore): added unit tests for Amplify Api Native Bridge #4983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit tests for Query, Mutate, Subscribe, and Unsubscribe
Equartey
approved these changes
Jun 7, 2024
Jordan-Nelson
approved these changes
Jun 7, 2024
| group('NativeAmplifyAPI', () { | ||
| group('Query', () { | ||
| test('Should handle empty request/response', () async { | ||
| String document = ''; |
There was a problem hiding this comment.
Note: DataStore doesn't follow amplify lints, but just an fyi in other packages where amplify_lints using final is enforced for local vars that are not mutated. The same probably applies to other lint rules.
I am going to see how much work enable amplify_lints in datastore will be. If/when it is added these are updates dart fix will make automatically.
You don't need to update these. Just wanted to make a note.
| return GraphQLOperation<String>( | ||
| CancelableOperation<GraphQLResponse<String>>.fromValue( | ||
| GraphQLResponse<String>( | ||
| data: data as String?, |
There was a problem hiding this comment.
Note: The fact that this is making you cast to String? is odd. I think this is a bug in Dart. I created a minimal repro of this and opened an issue: dart-lang/sdk#55958
Equartey
pushed a commit
that referenced
this pull request
Jun 10, 2024
* chore(datastore): added unit tests for Amplify Api Native Bridge Unit tests for Query, Mutate, Subscribe, and Unsubscribe * chore(datastore): updated Amplify Api Native Bridge unit tests per feedback * chore(datastore): Formatted file
Jordan-Nelson
pushed a commit
that referenced
this pull request
Jun 27, 2024
* chore(datastore): added unit tests for Amplify Api Native Bridge Unit tests for Query, Mutate, Subscribe, and Unsubscribe * chore(datastore): updated Amplify Api Native Bridge unit tests per feedback * chore(datastore): Formatted file
Jordan-Nelson
pushed a commit
that referenced
this pull request
Jun 27, 2024
* chore(datastore): added unit tests for Amplify Api Native Bridge Unit tests for Query, Mutate, Subscribe, and Unsubscribe * chore(datastore): updated Amplify Api Native Bridge unit tests per feedback * chore(datastore): Formatted file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.