Skip to content

Fix/spm api bridge unit tests #4957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix/spm api bridge unit tests #4957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
820dcd5
Update amplify_datastore.dart
tyllark May 31, 2024
a67a26c
Update native_api_helpers.dart
tyllark May 31, 2024
bc41907
Added unit tests for nativeAmplifyApi
tyllark May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/amplify_datastore/lib/amplify_datastore.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ class AmplifyDataStore extends DataStorePluginInterface
if (apiPlugin != null && gqlConfig != null) {
// ignore: invalid_use_of_protected_member
final authProviders = apiPlugin.authProviders;
final nativePlugin = _NativeAmplifyApi(authProviders);
final nativePlugin = NativeAmplifyApi(authProviders);
NativeApiPlugin.setup(nativePlugin);

final nativeBridge = NativeApiBridge();
Expand Down Expand Up @@ -288,10 +288,11 @@ class _NativeAmplifyAuthCognito
String get runtimeTypeName => '_NativeAmplifyAuthCognito';
}

class _NativeAmplifyApi
@visibleForTesting
class NativeAmplifyApi
with AWSDebuggable, AmplifyLoggerMixin
implements NativeApiPlugin {
_NativeAmplifyApi(this._authProviders);
NativeAmplifyApi(this._authProviders);

/// The registered [APIAuthProvider] instances.
final Map<APIAuthorizationType<AmplifyAuthProvider>, APIAuthProvider>
Expand Down
3 changes: 1 addition & 2 deletions packages/amplify_datastore/lib/src/utils/native_api_helpers.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import 'dart:convert';

import 'package:amplify_core/amplify_core.dart';
import 'package:amplify_datastore/src/native_plugin.g.dart';
import 'package:collection/collection.dart';

/// Convert a [NativeGraphQLResponse] to a [GraphQLResponse]
GraphQLRequest<String> nativeRequestToGraphQLRequest(
Expand Down Expand Up @@ -39,7 +38,7 @@ APIAuthorizationType? nativeToApiAuthorizationType(String? authMode) {
NativeGraphQLResponse graphQLResponseToNativeResponse(
GraphQLResponse<String> response) {
final errorJson = jsonEncode(
response.errors.whereNotNull().map((e) => e.toJson()).toList());
response.errors.map((e) => e.toJson()).toList());
return NativeGraphQLResponse(
payloadJson: response.data,
errorsJson: errorJson,
Expand Down
Loading
Loading