fix(datastore): Various integration bug fixes #4954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyllark
reviewed
May 31, 2024
| /// If the response has errors, the event type will be `error`, otherwise `data` | ||
| void sendSubscriptionEvent( | ||
| String subscriptionId, GraphQLResponse<String> response) { | ||
| final payloadJson = response.hasErrors |
There was a problem hiding this comment.
I recommend reusing sendNativeErrorEvent with the encoded error json if the response has errors.
There was a problem hiding this comment.
Good suggestion, updated.
NikaHsn
approved these changes
May 31, 2024
tyllark
approved these changes
May 31, 2024
Equartey
changed the title
Jordan-Nelson
approved these changes
Jun 3, 2024
| ) { a, _ in a } | ||
| }.map { JSONValue.object($0) } ?? dataPayload | ||
|
|
||
| /// This is included to allow multi-platform support. Requests that do not have `__typename` |
There was a problem hiding this comment.
q: Was there supposed to be more to this comment? I am not following the second sentence.
There was a problem hiding this comment.
Hm, yah reads like a fragment 😅 Updated.
Jordan-Nelson
approved these changes
Jun 3, 2024
tyllark
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
modelNamewhich should always have a value.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.