test(swift): add unit test cases for extension functions #4894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5d
force-pushed
the
5d/datastore-spm-swift-helper-functions-unit-test
branch
from
94b54d7 to
bc5fa5a
Compare
packages/amplify_datastore/example/ios/unit_tests/GraphQLRequestExtensionTests.swift
Outdated
Show resolved
Hide resolved
packages/amplify_datastore/example/ios/unit_tests/PublisherExtensionTests.swift
Outdated
Show resolved
Hide resolved
| subject.send(completion: .finished) | ||
| } | ||
|
|
||
| await fulfillment(of: [expectation1, expectation2, expectation3], timeout: 1) |
There was a problem hiding this comment.
The tests are failing in CI with the message
❌ /Users/runner/work/amplify-flutter/amplify-flutter/packages/amplify_datastore/example/ios/unit_tests/PublisherExtensionTests.swift:39:15: cannot find 'fulfillment' in scope
There was a problem hiding this comment.
Thanks for reviewing @Jordan-Nelson.
The API fulfillment mentioned in the error log was introduced in Xcode 14.3.
As discussed with @Equartey, to utilize the datastore v2, flutter will need to update the CI GitHub runner to macOS-14 or macOS-14-arm64, as the minimum supported version for datastore v2 has been updated to Swift 5.9.
Equartey
force-pushed
the
5d/datastore-spm-swift-helper-functions-unit-test
branch
from
4929406 to
3b8478f
Compare
Co-authored-by: Jordan Nelson <Jordanryannelson@gmail.com>
Jordan-Nelson
approved these changes
May 29, 2024
NikaHsn
approved these changes
May 29, 2024
Equartey
pushed a commit
to Equartey/amplify-flutter
that referenced
this pull request
May 29, 2024
Equartey
pushed a commit
that referenced
this pull request
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.