Skip to content

Added IOT Core device service to service list #3971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

joshiji
Copy link
Contributor

@joshiji joshiji commented Oct 20, 2023

Issue #, if available: None

Description of changes:
Added iotdevicegateway to the list of AWS services. It is needed to create signed WebSocket URL for MQTT connection to AWS IoT Core service as mentioned on this page.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@joshiji joshiji requested a review from a team as a code owner October 20, 2023 05:52
@tyllark
Copy link
Member

tyllark commented Jun 11, 2025

Sorry for the nearly 2 year delayed response, but the changes look good to me! If you are still interested, please update the branch (merge main into it) I'll get it merged.

@tyllark
Copy link
Member

tyllark commented Jun 23, 2025

CI/CD was failing due to repository permissions on external branches. I cherry picked the changes and merged them in this PR. Thanks for the submission!

@tyllark tyllark closed this Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants