Skip to content

refactor: category-auth, category-geo, and category-predictions to SDK V3 #14221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 44 commits into from
Jul 18, 2025

Conversation

ShadowCat567
Copy link
Contributor

@ShadowCat567 ShadowCat567 commented Jun 20, 2025

Description of changes

Migrating:

  • amplify-category-auth
  • amplify-category-predictions
  • amplify-category-geo

Partially migrating (some of the packages that are being fully migrated rely on functionality in these packages):

  • amplify-provider-awscloudformation
  • amplify-util-import

Initially was supposed to include amplify-e2e-tests and amplify-e2e-core, but they proved to be more complicated to migrate than anticipated and are being indefinitely put on hold since they are test changes and not as important as live code changes.
Also had to increase the size of the binaries.

Proxy should still work as expected, was able to add auth and geo and push while proxy was active. Attempted to update auth and geo while proxy was turned off, amplify push with the updates failed as expected.

Several e2e tests are failing on this PR that are unrelated to the SDK migrations changes:

  • These tests are known to be flaky/prone to failure due to Pinpoint deprecation
    • w_notifications_sms_update_notifications_multi_env
  • These tests are failing because glob dropped support for Node 18 and our Windows image still uses it, they will be fixed once we upgrade our Windows image
    • w_notifications_analytics_compatibility_in_app_2_init_e
    • w_api_7_api_10
    • w_auth_6_storage_1b
    • w_schema_searchable_apigw

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ShadowCat567 ShadowCat567 changed the title SDK Migrations 1: Packages that already have V3 imports refactor: Amplify categories that already have V3 imports Jul 9, 2025
@ShadowCat567 ShadowCat567 changed the title refactor: Amplify categories that already have V3 imports refactor: category-auth, category-geo, and category-prediction to SDK V3 Jul 11, 2025
@ShadowCat567 ShadowCat567 changed the title refactor: category-auth, category-geo, and category-prediction to SDK V3 refactor: category-auth, category-geo, and category-predictions to SDK V3 Jul 11, 2025
@ShadowCat567 ShadowCat567 marked this pull request as ready for review July 16, 2025 19:58
@ShadowCat567 ShadowCat567 requested a review from a team as a code owner July 16, 2025 19:58
@ShadowCat567 ShadowCat567 merged commit 55f186d into dev Jul 18, 2025
5 of 6 checks passed
@ShadowCat567 ShadowCat567 deleted the sdk-migrations-1 branch July 18, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants