fix: maintain custom sandbox identifier after file changes #2875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running sandbox with --identifier flag, the custom identifier now persists throughout the entire session, including after file changes trigger rebuilds. Previously, the identifier would fall back to default (whoami) after file changes because printSandboxNameInfo() was called without passing the sandboxIdentifier parameter. Fixes aws-amplify#2874 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
alexlau811
force-pushed
the
fix-sandbox-identifier-persistence
branch
from
01f7a38 to
3a3fa02
Compare
🦋 Changeset detectedLatest commit: 3a3fa02 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Amplifiyer
reviewed
Jul 2, 2025
|
@alexlau811 are you able to add some unit test coverage to this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where the sandbox identifier falls back to the default value (whoami) after file changes are detected by the file watcher.
--identifierflag persists throughout the entire sandbox sessionsandboxIdentifierparameter toprintSandboxNameInfo()when called from the file watcherIssue
Fixes #2874
Description of Changes
In
packages/sandbox/src/file_watching_sandbox.ts, the file watcher was callingprintSandboxNameInfo()without passing thesandboxIdentifierparameter. This caused the method to fall back to using the default identifier (whoami) instead of the custom one provided by the user.The fix is simple: pass
options.identifierto the method call on line 224.Test Plan
Manual Testing
Expected Behavior
Verification
npm run lint)npm run build)Checklist
🤖 Generated with Claude Code