Skip to content

Add integ test for #PR325 #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: test: multiple container names
merged 2 commits into from
Feb 10, 2025
Merged

Add integ test for #PR325 #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f600840
Add integ test for PR325
kg-aws Feb 10, 2025
1409cd8
latest as revision doesn't work with ARN
kg-aws Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
id: render-task-definition-arn
uses: aws-actions/amazon-ecs-render-task-definition@1048d8f8eb80d018c1bed7b5e3b252148bd6dfe5
with:
task-definition-arn: arn:aws:ecs:us-west-2:397300886559:task-definition/github-actions-render-task-definition-integ-tests:16
task-definition-arn: arn:aws:ecs:us-west-2:${{ secrets.AWS_ACCOUNT_ID }}:task-definition/github-actions-render-task-definition-integ-tests:16
container-name: sample-app
image: amazon/amazon-ecs-sample:latest

Expand Down
8 changes: 7 additions & 1 deletion expected-task-definition.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,11 @@
"FARGATE"
],
"networkMode": "awsvpc",
"cpu": "256"
"cpu": "256",
"tags": [
{
"key": "test-name",
"value": "github-actions-render-task-definition-integ-tests"
}
]
}
8 changes: 7 additions & 1 deletion task-definition.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,11 @@
"FARGATE"
],
"networkMode": "awsvpc",
"cpu": "256"
"cpu": "256",
"tags": [
{
"key": "test-name",
"value": "github-actions-render-task-definition-integ-tests"
}
]
}
2 changes: 1 addition & 1 deletion test-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
id: render-task-definition-arn
uses: aws-actions/amazon-ecs-render-task-definition@v1
with:
task-definition-arn: arn:aws:ecs:us-west-2:397300886559:task-definition/github-actions-render-task-definition-integ-tests:16
task-definition-arn: arn:aws:ecs:us-west-2:${{ secrets.AWS_ACCOUNT_ID }}:task-definition/github-actions-render-task-definition-integ-tests:16
container-name: sample-app
image: amazon/amazon-ecs-sample:latest

Expand Down