Skip to content

ExtensionLoader was not adding the service loaded AdapterFactories and Ann… #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

rbygrave
Copy link
Contributor

…otationFactories

Adds the service loaded AdapterFactories and AnnotationFactores.

I'm not sure if these were not included for a reason? This PR assumes that was just an omission, and they should be added.

…otationFactories

Adds the service loaded AdapterFactories and AnnotationFactores.

I'm not sure if these were not included for a reason? This PR assumes that was just an omission, and they should be added.
@rbygrave rbygrave requested a review from SentryMan May 29, 2025 20:47
@rbygrave rbygrave self-assigned this May 29, 2025
@rbygrave rbygrave changed the title ExtensionLoader was not using service loaded AdapterFactories and Ann… ExtensionLoader was not adding the service loaded AdapterFactories and Ann… May 29, 2025
@SentryMan SentryMan merged commit c8043b8 into main May 29, 2025
7 checks passed
@SentryMan SentryMan deleted the feature/ExtensionLoader-extra branch May 29, 2025 21:09
@SentryMan SentryMan added this to the 2.12 milestone Jun 5, 2025
@SentryMan SentryMan added the bug Something isn't working label Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants