fix: handle nested java types like Flow.Publisher in Util.shortName #826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SentryMan
approved these changes
Jun 8, 2025
|
Nice, but there is insufficient test coverage here and this PR should NOT have been merged without that coverage @SentryMan |
Is there something missing? Looks 100% to me with all code paths hit. The problem described was not about wiring, but the generation of invalid code. We already have tests for wiring things with |
rbygrave
added a commit
that referenced
this pull request
Jun 9, 2025
- Move the test objects GenericImpl, GenericInterfaceObject to blackbox-test-inject - Long term it is not sufficient to compile but actually have a test that confirms it wires - Also tidy UtilTest to merge the tests for shortName() + add some java types to that test
Yeah I was wrong. Test coverage there was ok. I was concerned about missing coverage on the java types but was wrong there. |
SentryMan
added a commit
that referenced
this pull request
Jun 9, 2025
Test only followup for #826, add test to blackbox-test-inject
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in Util.shortName(...) where nested types like java.util.concurrent.Flow.Publisher were resolved incorrectly as Publisher, which caused generated code to fail compilation when the short name was not imported correctly.