Graceful shutdown - defaults for io.ebean.Database to shutdown() last #820
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For graceful shutdown, we desire components to shutdown in an appropriate order. For
io.ebean.Database
it should be shutdown last.Adds a default shutdown method and shutdown priority for special components such that they default to doing "the right thing" wrt graceful shutdown.
For ebean:
We desire that to effectively default to:
... we want the generated code to have
addPreDestroy()
like: