Evm blindsign #393
Merged
Evm blindsign #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements streaming mode for processing large ETH transactions that exceed buffer capacity. Adds UI support to display transaction hash for blind signing. Includes chain ID extraction to support EIP-155 signature compatibility.
abenso
reviewed
Sep 30, 2025
| parser_nft_info_not_provided, | ||
| parser_invalid_contract_address, | ||
| parser_context_unexpected_size, | ||
| parser_blind_sign_not_enabled = 41, |
There was a problem hiding this comment.
Any reason to set a specific value here?
There was a problem hiding this comment.
The error will be triggered in Rust, and in the error structure the available error code was 41, so I had to set it to be the same in C, so we could compare.
app/src/apdu_handler.c
Outdated
| memcpy(G_io_apdu_buffer, error_msg, error_msg_length); | ||
| *tx += (error_msg_length); | ||
| THROW(APDU_CODE_DATA_INVALID); | ||
| if (strcmp(error_msg, "Blind signing not enabled") == 0) { |
There was a problem hiding this comment.
If we have an error here, the app_reply_error callback will be called. There, the offset in set_code is set to 0, so the error description is missing. You need to store the offset of the error description here so it can be used in app_reply_error
abenso
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.