Dev

app/Makefile

@@ -125,9 +125,9 @@ INCLUDES_PATH += $(CURDIR)/src/common/
 CC := $(CLANGPATH)clang
 
 ifeq ($(DEBUG), 1)
-CFLAGS += -O3 -Os -Wno-unknown-pragmas -Wno-unused-parameter -g
+CFLAGS += -O3 -Os -Wno-unknown-pragmas  -g
 else
-CFLAGS += -O3 -Os -Wno-unknown-pragmas -Wno-unused-parameter
+CFLAGS += -O3 -Os -Wno-unknown-pragmas
 endif
 
 CFLAGS += -DAPPVERSION_M=$(APPVERSION_M) -DAPPVERSION_N=$(APPVERSION_N) -DAPPVERSION_P=$(APPVERSION_P)

app/Makefile.version

@@ -3,4 +3,4 @@ APPVERSION_M=1
 # Minor
 APPVERSION_N=2
 # Patch
-APPVERSION_P=2
+APPVERSION_P=3

app/src/addr.c

@@ -43,7 +43,7 @@ zxerr_t app_fill_ed25519_address(uint8_t *buffer, uint16_t buffer_len, uint16_t
 }
 
 zxerr_t fill_address(
-    uint32_t *flags,
+    __Z_UNUSED uint32_t *flags,
     uint32_t *tx,
     uint32_t rx,
     uint8_t *buffer,
@@ -54,10 +54,10 @@ zxerr_t fill_address(
     zemu_log("fill_address\n");
     zxerr_t err = zxerr_ok;
     if (curve_type == CURVE_ED25519) {
-        err = app_fill_ed25519_address(G_io_apdu_buffer, IO_APDU_BUFFER_SIZE -2, &action_addrResponseLen);
+        err = app_fill_ed25519_address(buffer, buffer_len, &action_addrResponseLen);
         *tx = action_addrResponseLen;
     } else {
-        err = _app_fill_address(tx, rx, G_io_apdu_buffer, IO_APDU_BUFFER_SIZE, addr_ui_obj, ADDR_UI_MAX_SIZE);
+        err = _app_fill_address(tx, rx, buffer, buffer_len, addr_ui_obj, ADDR_UI_MAX_SIZE);
         action_addrResponseLen = *tx;
     }
 

app/src/apdu_handler.c

@@ -416,7 +416,7 @@ __Z_INLINE void avax_dispatch(volatile uint32_t *flags, volatile uint32_t *tx, u
     }
 }
 
-__Z_INLINE void handleEthConfig(volatile uint32_t *flags, volatile uint32_t *tx, uint32_t rx) {
+__Z_INLINE void handleEthConfig(volatile uint32_t *flags, volatile uint32_t *tx, __Z_UNUSED uint32_t rx) {
     zemu_log("handleEthConfig\n");
     *tx = 0;
     app_eth_configuration();
@@ -448,7 +448,7 @@ __Z_INLINE void handleNftInfo(volatile uint32_t *flags, volatile uint32_t *tx, u
 }
 
 
-__Z_INLINE void handleProvideErc20(volatile uint32_t *flags, volatile uint32_t *tx, uint32_t rx) {
+__Z_INLINE void handleProvideErc20(volatile uint32_t *flags, volatile uint32_t *tx, __Z_UNUSED uint32_t rx) {
     zemu_log("handleProvideErc20\n");
 
     // Nothing to do as we do not handle this information,
@@ -461,7 +461,7 @@ __Z_INLINE void handleProvideErc20(volatile uint32_t *flags, volatile uint32_t *
     *flags |= IO_ASYNCH_REPLY;
 }
 
-__Z_INLINE void handleSetPlugin(volatile uint32_t *flags, volatile uint32_t *tx, uint32_t rx) {
+__Z_INLINE void handleSetPlugin(volatile uint32_t *flags, volatile uint32_t *tx, __Z_UNUSED uint32_t rx) {
     zemu_log("handleSetPlugin\n");
 
     // This instruction is sent in the process of providing

app/src/handler.c

@@ -185,8 +185,8 @@ void init_coin_config(chain_config_t *coin_config) {
  * @note This function sets the blockchain configuration on the first call and logs each operation.
  *       It includes extensive error handling to gracefully manage exceptions and reset the context as needed.
  */
-void handle_eth_apdu(uint32_t *flags, uint32_t *tx,
-                     uint32_t rx, uint8_t *buffer, uint16_t bufferLen) {
+void handle_eth_apdu(__Z_UNUSED uint32_t *flags, uint32_t *tx,
+                    __Z_UNUSED uint32_t rx,  uint8_t *buffer, __Z_UNUSED uint16_t bufferLen) {
     unsigned short sw = 0;
 
     // This is the best place to put this,

app/src/wallet_id.c

@@ -32,8 +32,6 @@
 // Use to hold the addr_ui object, used by rust to display the address
 uint8_t addr_ui_obj[WALLET_UI_MAX_SIZE] = {0};
 
-
-
 zxerr_t fill_wallet_id(
     uint32_t *tx,
     uint32_t rx,
@@ -49,7 +47,7 @@ zxerr_t fill_wallet_id(
         zemu_log(data);
     }
 
-    zxerr_t err = _app_fill_wallet(tx, rx, G_io_apdu_buffer, IO_APDU_BUFFER_SIZE, addr_ui_obj, WALLET_UI_MAX_SIZE);
+    zxerr_t err = _app_fill_wallet(tx, rx, buffer, buffer_len, addr_ui_obj, WALLET_UI_MAX_SIZE);
 
     if (err != zxerr_ok)
         action_addrResponseLen = 0;

app/src/wallet_id.h

@@ -20,7 +20,6 @@
 extern "C" {
 #endif
 
-
 zxerr_t fill_wallet_id(
     uint32_t *tx,
     uint32_t rx,

app/src/xaddr.c

@@ -32,10 +32,8 @@
 // Use to hold the addr_ui object, used by rust to display the address
 uint8_t xaddr_ui_obj[ADDR_UI_MAX_SIZE] = {0};
 
-
-
 zxerr_t fill_ext_address(
-    uint32_t *flags,
+    __Z_UNUSED uint32_t *flags,
     uint32_t *tx,
     uint32_t rx,
     uint8_t *buffer,
@@ -44,7 +42,7 @@ zxerr_t fill_ext_address(
 
     zemu_log("fill_ext_address\n");
 
-    zxerr_t err = _app_fill_ext_address(tx, rx, G_io_apdu_buffer, IO_APDU_BUFFER_SIZE, xaddr_ui_obj, ADDR_UI_MAX_SIZE);
+    zxerr_t err = _app_fill_ext_address(tx, rx, buffer, buffer_len, xaddr_ui_obj, ADDR_UI_MAX_SIZE);
 
     if (err != zxerr_ok)
         action_addrResponseLen = 0;

app/src/xaddr.h

@@ -22,7 +22,7 @@ extern "C" {
 
 
 zxerr_t fill_ext_address(
-    uint32_t *flags,
+    __Z_UNUSED uint32_t *flags,
     uint32_t *tx,
     uint32_t rx,
     uint8_t *buffer,