Skip to content

Conversation

@alarso16
Copy link
Contributor

Why this should be merged

The golang binding tests had a race with libevm registrations, so I also fixed the flake.

Closes #1364

How this works

Add race detection, registers libevm globally

How this was tested

Existing CI

Need to be documented?

No

Need to update RELEASES.md?

No

@alarso16 alarso16 self-assigned this Oct 24, 2025
@alarso16 alarso16 marked this pull request as ready for review October 24, 2025 17:09
@alarso16 alarso16 requested a review from a team as a code owner October 24, 2025 17:09
Copy link
Collaborator

@ARR4N ARR4N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! TIL that those aren't separate test binaries (I hate the bind tests).

alarso16 and others added 3 commits October 27, 2025 14:03
Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com>
Signed-off-by: Austin Larson <78000745+alarso16@users.noreply.github.com>
@ARR4N ARR4N added this pull request to the merge queue Oct 27, 2025
Merged via the queue into master with commit 53b9eb4 Oct 27, 2025
9 checks passed
@ARR4N ARR4N deleted the alarso16/bindings-flake branch October 27, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GolangBindings flake

4 participants