test: Update rpc tests to reduce flake likelihood #1363
Merged
+87
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alarso16
added
bug
ARR4N
approved these changes
Oct 27, 2025
There was a problem hiding this comment.
Approving modulo my response in this thread as I don't need to re-review if you think the criteria are met.
JonathanOppenheimer
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Closes #1195 and #1396.
How this works
One of the tests was outdated from the tip of master in
go-ethereum, so it was updated. Additionally, this allows running all the tests in this pacakge multiple times if there is an error, reducing the chance that the package will flake.How this was tested
Existing UT
Need to be documented?
No
Need to update RELEASES.md?
No.