test: Fix state sync flakes #1361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alarso16
added
bug
JonathanOppenheimer
approved these changes
Oct 24, 2025
powerslider
approved these changes
Oct 28, 2025
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: Austin Larson <78000745+alarso16@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Since the state syncer can have multiple workers, there may be multiple in flight requests when it should start returning errors. Therefore, the number may be atomically increased more than twice.
For the other test, I haven't been able to replicate it locally. In order to see it flake (if it still does), I think we should remove it from the list of flakes
Closes #1357
How this works
Provides lower bound.
How this was tested
Unable to reproduce, likely needs small machine.
Need to be documented?
No.
Need to update RELEASES.md?
No.