test: Fix mempool flakes #1360
Merged
test: Fix mempool flakes #1360
+79
−381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alarso16
added
bug
JonathanOppenheimer
approved these changes
Oct 24, 2025
geoff-vball
reviewed
Oct 24, 2025
geoff-vball
reviewed
Oct 24, 2025
geoff-vball
reviewed
Oct 27, 2025
alarso16
force-pushed
the
alarso16/mempool-flakes
branch
from
bfd82ee to
34355e9
Compare
alarso16
force-pushed
the
alarso16/mempool-flakes
branch
from
4bdb916 to
2a6d166
Compare
alarso16
commented
Oct 27, 2025
JonathanOppenheimer
approved these changes
Oct 28, 2025
StephenButtolph
approved these changes
Oct 28, 2025
Signed-off-by: Stephen Buttolph <stephen@avalabs.org>
StephenButtolph
approved these changes
Oct 28, 2025
powerslider
reviewed
Oct 28, 2025
| // Tests that conflicting txs are handled, based on whether the original tx is | ||
| // valid or not. | ||
| func TestAtomicTxPushGossipInboundConflicting(t *testing.T) { | ||
| require := require.New(t) |
There was a problem hiding this comment.
You don't need this. The only thing it achieves is implicitly passing testing.T to the concrete require assertion call, but it adds unnecessary noise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Closes #1356 as pre-req for monorepo. These tests were hazy in scope anyway and didn't accurately test what it intended to.
How this works
It removes one of the tests, and combines two of the tests utilizing the
AppGossipfunction instead.How this was tested
UT
Need to be documented?
No
Need to update RELEASES.md?
No