-
Couldn't load subscription status.
- Fork 159
use average for block tips after Granite #1342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+160
−479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into ceyonur/min-required-tip
alarso16
approved these changes
Oct 28, 2025
powerslider
approved these changes
Oct 28, 2025
StephenButtolph
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
We have removed block gas cost with ACP-226 so we cannot return any estimation based on block gas costs.
How this works
SuggesTipCapthen takes the percentile of those estimated tips. Now we're forming a dataset from all txs and their tips and then taking the percentile.How this was tested
Added UTs, simulated mainnet tips.
The current mainnet tx medians are converging to the 1000 wei e.g:
Need to be documented?
Changed documentation slightly
Need to update RELEASES.md?
yes