Kill zombie tasks when finalizing #284
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a functionality to the task scheduler that enables to kill tasks not yet ready to run, and kills these tasks if they will never be executed, in order to avoid these tasks from residing in the memory for ever. Since blocks are verified in-order, it is only possible to verify a block if its parent block has been verified. Therefore, a task that verifies a block can be not yet ready to run only if its parent block has not yet been verified. This commit makes the Simplex instance kill all tasks that correspond to sequences that have been already finalized, as a block that corresponds to a sequence that is finalized, does not need to be verified. Signed-off-by: Yacov Manevich <yacov.manevich@avalabs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a functionality to the task scheduler that enables to kill tasks not yet ready to run, and kills these tasks if they will never be executed, in order to avoid these tasks from residing in the memory for ever.
Since blocks are verified in-order, it is only possible to verify a block if its parent block has been verified. Therefore, a task that verifies a block can be not yet ready to run only if its parent block has not yet been verified.
This commit makes the Simplex instance kill all tasks that correspond to sequences that have been already finalized, as a block that corresponds to a sequence that is finalized, does not need to be verified.