Add Replication of Notarizations #117
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samliok
force-pushed
the
note-replication
branch
from
a839697 to
bfaf226
Compare
samliok
commented
Mar 3, 2025
Signed-off-by: Sam Liokumovich <65994425+samliok@users.noreply.github.com>
Signed-off-by: Sam Liokumovich <65994425+samliok@users.noreply.github.com>
samliok
changed the title
yacovm
reviewed
Mar 6, 2025
replication.go
Outdated
|
|
||
| func (r *ReplicationState) collectFutureNotarizations(currentRound uint64) { | ||
| // round to start collecting notarizations | ||
| start := max(r.highestNotarizedRound(), currentRound) |
There was a problem hiding this comment.
what if we have "holes" in the receivedNotarizations? e.g if we asked starting from round 100 and we are given rounds 101, 103, 104...
We will never replicate 102 with this logic.
There was a problem hiding this comment.
we have the same problem with requesting finalization certificates as well. I think for this PR we should assume our requests are responded to in full, and handle incomplete requests in a later pr. I think we can add it in the same PR as #82
epoch.go
Outdated
| if !ok { | ||
| emptyVotes, ok := e.emptyVotes[currentRound] | ||
| if !ok || emptyVotes.emptyNotarization == nil { | ||
| // this can happen because we deleted an old empty notarization |
There was a problem hiding this comment.
we can only delete it if we have indexed it in storage, no? So shouldn't we retrieve it from storage for that node?
samliok
force-pushed
the
note-replication
branch
from
e875f04 to
c15c5b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.