feat(autoware_adapi_v1_msgs): update manual control messages #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
yukkysaito
reviewed
Mar 26, 2025
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
yukkysaito
reviewed
Mar 28, 2025
| @@ -17,7 +17,7 @@ rosidl_generate_interfaces(${PROJECT_NAME} | |||
| manual/msg/HazardLightsCommand.msg | |||
| manual/msg/ManualControlMode.msg | |||
| manual/msg/ManualControlModeStatus.msg | |||
| manual/msg/ManualOperatorStatus.msg | |||
| manual/msg/ManualOperatorHeartbeat.msg | |||
There was a problem hiding this comment.
Would it be appropriate to include this change in this PR?
There was a problem hiding this comment.
It needed some other changes so I merged it into this PR. I updated the PR title and description so could you please check it again? The steering_tire_velocity additions have also been merged.
isamu-takagi
changed the title
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
mitsudome-r
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix following problems identified through prototyping
acceleratortothrottlebecause it's confusingly similar toacceleration.ManualOperatorHeartbeatto make the purpose clearsteering_tire_velocitythat is a necessary parameter for steering control.How was this PR tested?
None
Notes for reviewers
None.
Effects on system behavior
None.