feat: add code owners documentation #546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
xmfcx
added
type:documentation
|
Documentation URL: https://autowarefoundation.github.io/autoware-documentation/pr-546/ |
esteve
approved these changes
May 2, 2024
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
|
@xmfcx I've reviewed this PR before the latest changes 😅 Are there more changes coming or should I review the PR as is now? |
|
So fast @esteve :D I am also reviewing it with chatgpt and will do some wording and formatting improvements with that but the core information will stay the same. |
added 2 commits
May 2, 2024 14:40
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
|
Alright it's ready now 😁 |
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
|
I'll merge it for now, if you have any reviews or comments, I will open up a new PR to also apply them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.