Skip to content

feat(calibration tool): add description of TIER IV calibration tool #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat(calibration tool): add description of TIER IV calibration tool #188

wants to merge 10 commits into from
+58 −2

Conversation

yabuta
Copy link

@yabuta yabuta commented Aug 30, 2022 •
edited
Loading

Description

Add a description of the Calibration Tool being developed in TIER IV.

Releted: https://github.com/tier4/CalibrationTools

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@yabuta
Copy link
Author

yabuta commented Aug 30, 2022

Translate into English after discussion

@yabuta
Copy link
Author

yabuta commented Aug 30, 2022

@mitsudome-r
If I explain how to install the calibration tool, would it be better to write it here?
https://autowarefoundation.github.io/autoware-documentation/main/installation/related-tools/

@yabuta yabuta marked this pull request as ready for review August 30, 2022 05:15
@yabuta yabuta marked this pull request as draft August 30, 2022 05:15
@yabuta
Copy link
Author

yabuta commented Oct 4, 2022

@mitsudome-r @aohsato @knzo25
Can I ask you to first confirm that you would like to review the written content in Japanese?
Also, please give me your opinion on whether or not to add the installation method of the calibration tool to the related tools in the INSTALLATION section in this PR.

yabuta added 3 commits October 31, 2022 10:08
@yabuta
merge main
ba4e8ee
@yabuta
Merge branch 'add-description-of-tier4-calibration-tool' of github.co…
6d133f1 
…m:yabuta/autoware-documentation into add-description-of-tier4-calibration-tool
@yabuta
add installation
47568db
@yabuta yabuta marked this pull request as ready for review October 31, 2022 01:13
@yabuta
Copy link
Author

yabuta commented Oct 31, 2022

@aohsato @mitsudome-r @knzo25
May I first ask for confirmation in Japanese?

@yukkysaito
Copy link
Contributor

yukkysaito commented Jan 29, 2023 •
edited
Loading

@yabuta Looks good.
I would like to merge it once because of the demand, can you please translate it into English? Let's revise again if there are any problems.

yukkysaito
yukkysaito reviewed Jan 29, 2023
View reviewed changes
docs/installation/related-tools/index.md

Under Construction
### Install Calibration of TIER IV
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to use from or provided by. I am not sure about the grammar and may be wrong.

Suggested change
### Install Calibration of TIER IV
### Install Calibration tools from TIER IV

yukkysaito
yukkysaito reviewed Jan 29, 2023
View reviewed changes
docs/how-to-guides/calibrating-your-sensors.md
- [Extrinsic ground-plane Calibration](https://github.com/tier4/CalibrationTools/tree/tier4/universe/sensor#base-lidar-calibration)
- roll, pitch, z を自動でキャリブレーションするツールです。

## Other Calibration Tools from TIER IV
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Other Calibration Tools from TIER IV
## Other calibration tools from TIER IV

yukkysaito
yukkysaito reviewed Jan 29, 2023
View reviewed changes
docs/installation/related-tools/index.md
@@ -1,5 +1,17 @@
# Installation of related tools

!!! warning
## Calibration Tool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Calibration Tool
## Calibration tools

@stale
Copy link

stale bot commented Mar 30, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Mar 30, 2023
@knzo25 knzo25 removed their request for review April 1, 2024 02:10
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Apr 1, 2024
@stale Stale
Copy link

stale bot commented Jun 1, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jun 1, 2024
@knzo25
Copy link
Contributor

knzo25 commented Jul 22, 2024

@yabuta
If you are not going to work on this, please close it

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Jul 22, 2024
@stale Stale
Copy link

stale bot commented Sep 20, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukkysaito yukkysaito yukkysaito left review comments

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r

@aohsato aohsato Awaiting requested review from aohsato

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
status:stale Inactive or outdated issues. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yabuta @yukkysaito @knzo25