Sim info dict #601
Open
Sim info dict #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all dict entries be json compatible.
|
I feel that this part is such a hub we either make is more generic accepting a output config or use the power of oop and override the run method. |
|
@blown302 Which part do you mean? If you mean the drive code, I’ve converted it to a class with multiple methods that can be overridden, in my fork. |
|
No the gym part |
|
Looks like a useful way to get data into the tubs. I like it. |
That seems like it would be a relatively easy change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for saving dict's to Tub files, provided all entries are json compatible. Also add an option and support to drive and gym code to save the simulator's info dictionary (reward and done flags, cte, hit flag, position, etc.).
See issue #583 .