Skip to content

chore: update rust toolchain, migrate to 2024 edition #3535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/sc-consensus-subspace/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
//!
//! All of the modules here are crucial for consensus, open each module for specific details.

#![feature(let_chains, try_blocks, duration_constructors)]
#![feature(let_chains, try_blocks, duration_constructors_lite)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Search and replace:

fastmod --accept-all --fixed-strings 'duration_constructors' 'duration_constructors_lite'

#![forbid(unsafe_code)]
#![warn(missing_docs)]

Expand Down
2 changes: 1 addition & 1 deletion crates/subspace-farmer/src/bin/subspace-farmer/main.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#![feature(duration_constructors, type_changing_struct_update)]
#![feature(duration_constructors_lite, type_changing_struct_update)]

mod commands;
mod utils;
Expand Down
2 changes: 1 addition & 1 deletion crates/subspace-farmer/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
array_windows,
assert_matches,
btree_extract_if,
duration_constructors,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this just a rename or anything changed that we should be aware of ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, the lite version includes from_mins and from_hours, we use from_mins only.
(Days, weeks, and larger time units have issues with daylight saving time, civil time, and scientific time rust-lang/rust#140881)

duration_constructors_lite,
exact_size_is_empty,
fmt_helpers_for_derive,
future_join,
Expand Down
2 changes: 1 addition & 1 deletion crates/subspace-service/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//! Service and ServiceFactory implementation. Specialized wrapper over substrate service.
#![feature(
duration_constructors,
duration_constructors_lite,
impl_trait_in_assoc_type,
int_roundings,
let_chains,
Expand Down
2 changes: 1 addition & 1 deletion domains/client/domain-operator/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
array_windows,
assert_matches,
box_into_inner,
duration_constructors,
duration_constructors_lite,
let_chains,
more_qualified_paths
)]
Expand Down