Skip to content

chore: update rust toolchain, migrate to 2024 edition #3535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 2, 2025
Merged

chore: update rust toolchain, migrate to 2024 edition #3535

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
76d0a35
feat: derive the edition from the workspace Cargo.toml
tediou5 May 16, 2025
c7266f8
chore: update rust toolchain and edition
tediou5 May 16, 2025
01af654
fix: set_var is unsafe now
tediou5 May 16, 2025
ff6cdea
fix: remove the unnecessary binding modifier
tediou5 May 16, 2025
8e253d7
fix: rename feature duration_constructors => duration_constructors_lite
tediou5 May 16, 2025
cd16809
fix: capture more lifetime to adjusted the RPIT lifetime capture rules
tediou5 May 16, 2025
fdb55de
fix: extern blocks must be unsafe
tediou5 May 16, 2025
543b372
chore: run cargo -Zgitoxide -Zgit clippy --locked --all-targets --fea…
tediou5 May 16, 2025
500f33a
chore: run cargo -Zgitoxide -Zgit clippy --locked --all-targets --fea…
tediou5 Jun 1, 2025
71f66d3
chore(clippy): replace clone with std::slice::from_ref
tediou5 Jun 1, 2025
5788435
chore: cargo fmt --all
tediou5 May 16, 2025
ad37d83
feat: remove let_chains feature
tediou5 May 16, 2025
272b30b
Fix another slice::from_ref and some dead code
teor2345 Jun 2, 2025
dc3b82e
Remove extra newline in subspace-gateway/Cargo.toml
teor2345 Jun 2, 2025
62e7ae5
Use rustfmt 2024 edition
teor2345 Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/pallet-domains/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
//! Pallet Domains

#![cfg_attr(not(feature = "std"), no_std)]
#![feature(array_windows, let_chains, variant_count)]
#![feature(array_windows, variant_count)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be automated using:

fastmod --accept-all --fixed-strings '#![feature(let_chains)]' ''
fastmod --accept-all --fixed-strings 'let_chains,' ''
cargo fmt --all


#[cfg(feature = "runtime-benchmarks")]
mod benchmarking;
Expand Down
2 changes: 1 addition & 1 deletion crates/pallet-subspace/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#![doc = include_str!("../README.md")]
#![cfg_attr(not(feature = "std"), no_std)]
#![feature(array_chunks, assert_matches, let_chains, portable_simd)]
#![feature(array_chunks, assert_matches, portable_simd)]
#![warn(unused_must_use, unsafe_code, unused_variables)]

#[cfg(not(feature = "std"))]
Expand Down
2 changes: 1 addition & 1 deletion crates/sc-consensus-subspace/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
//!
//! All of the modules here are crucial for consensus, open each module for specific details.

#![feature(let_chains, try_blocks, duration_constructors_lite)]
#![feature(try_blocks, duration_constructors_lite)]
#![forbid(unsafe_code)]
#![warn(missing_docs)]

Expand Down
2 changes: 0 additions & 2 deletions crates/sc-proof-of-time/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
//! Subspace proof of time implementation.

#![feature(let_chains)]

mod slots;
pub mod source;
pub mod verifier;
Expand Down
1 change: 0 additions & 1 deletion crates/sp-consensus-subspace/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

#![forbid(unsafe_code, missing_docs)]
#![cfg_attr(not(feature = "std"), no_std)]
#![feature(let_chains)]

extern crate alloc;

Expand Down
1 change: 0 additions & 1 deletion crates/subspace-farmer/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
impl_trait_in_assoc_type,
int_roundings,
iter_collect_into,
let_chains,
never_type,
result_flattening,
trait_alias,
Expand Down
1 change: 0 additions & 1 deletion crates/subspace-service/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
duration_constructors_lite,
impl_trait_in_assoc_type,
int_roundings,
let_chains,
type_alias_impl_trait,
type_changing_struct_update
)]
Expand Down
1 change: 0 additions & 1 deletion domains/client/block-builder/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
//! initialize a block, to push extrinsics and to finalize a block.

#![warn(missing_docs)]
#![feature(let_chains)]

mod custom_api;
mod genesis_block_builder;
Expand Down
1 change: 0 additions & 1 deletion domains/client/block-preprocessor/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
//! 5. Push back the potential new domain runtime extrisnic.

#![warn(rust_2018_idioms)]
#![feature(let_chains)]

pub mod inherents;
pub mod stateless_runtime;
Expand Down
1 change: 0 additions & 1 deletion domains/client/cross-domain-message-gossip/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#![feature(let_chains)]
#![warn(rust_2018_idioms)]

mod aux_schema;
Expand Down
1 change: 0 additions & 1 deletion domains/client/domain-operator/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@
assert_matches,
box_into_inner,
duration_constructors_lite,
let_chains,
more_qualified_paths
)]

Expand Down
1 change: 0 additions & 1 deletion domains/client/relayer/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#![feature(let_chains)]
#![warn(rust_2018_idioms)]
// TODO: Restore once https://github.com/rust-lang/rust/issues/122105 is resolved
// #![deny(unused_crate_dependencies)]
Expand Down
2 changes: 1 addition & 1 deletion domains/pallets/messenger/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
#![cfg_attr(not(feature = "std"), no_std)]
#![forbid(unsafe_code)]
#![warn(rust_2018_idioms)]
#![feature(let_chains, variant_count, if_let_guard)]
#![feature(variant_count, if_let_guard)]

#[cfg(feature = "runtime-benchmarks")]
mod benchmarking;
Expand Down
2 changes: 1 addition & 1 deletion shared/subspace-data-retrieval/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//! Fetching data from the archived history of the Subspace Distributed Storage Network.

#![feature(exact_size_is_empty, let_chains, trusted_len)]
#![feature(exact_size_is_empty, trusted_len)]

pub mod object_fetcher;
pub mod piece_fetcher;
Expand Down
Loading