Add development containers support #2379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have read the CLA Document and I hereby sign the CLA |
katallaxie
force-pushed
the
devcontainers
branch
2 times, most recently
from
f6889fa to
9155b04
Compare
vroldanbet
previously approved these changes
May 2, 2025
.devcontainer/devcontainer.json
Outdated
| "customizations": { | ||
| "vscode": { | ||
| "extensions": [ | ||
| "golang.go" |
There was a problem hiding this comment.
nit: maybe worth adding the spicedb extension? https://marketplace.visualstudio.com/items?itemName=authzed.spicedb-vscode
Also perhaps docker extension?
There was a problem hiding this comment.
Happy to do so. I wanted to keep the surface slim, but these are helpful.
vroldanbet
approved these changes
May 2, 2025
|
@katallaxie 👋🏻 are we ready to move forward with this PR? in that case, all we are missing is CLA signature |
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
recheck |
authzedbot
added a commit
to authzed/cla
that referenced
this pull request
May 26, 2025
vroldanbet
approved these changes
May 26, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The changes here add support for development containers to make it easy to spin-up a development environment.
To test this works with most of the tools the
go run cmd/spicedb/main.gowas run to run the server locally andmage -l.