Skip to content

Fixing a memory leak in knetfile.c. #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixing a memory leak in knetfile.c. #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ test/khash_keith2
test/khash_test
test/klist_test
test/kmin_test
test/knetfile_test
test/kseq_bench
test/kseq_bench2
test/kseq_test
Expand Down
11 changes: 9 additions & 2 deletions knetfile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,6 +582,7 @@ int knet_close(knetFile *fp)
free(fp->host); free(fp->port);
free(fp->response); free(fp->retr); // FTP specific
free(fp->path); free(fp->http_host); // HTTP specific
free(fp->size_cmd);
free(fp);
return 0;
}
Expand All @@ -591,7 +592,7 @@ int main(void)
{
char *buf;
knetFile *fp;
int type = 4, l;
int type = 5, l;
#ifdef _WIN32
knet_win32_init();
#endif
Expand All @@ -615,7 +616,13 @@ int main(void)
knet_seek(fp, 20000, SEEK_SET);
knet_seek(fp, 10000, SEEK_SET);
l = knet_read(fp, buf+10000, 10000000) + 10000;
}
} else if (type == 5) {
fp = knet_open("http://archive.debian.org/debian/README", "r");
knet_read(fp, buf, 10000);
knet_seek(fp, 20000, SEEK_SET);
knet_seek(fp, 10000, SEEK_SET);
l = knet_read(fp, buf+10000, 10000000) + 10000;
}
if (type != 4 && type != 1) {
knet_read(fp, buf, 255);
buf[255] = 0;
Expand Down
5 changes: 4 additions & 1 deletion test/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ CXX=g++
CFLAGS=-g -Wall -O2 -I..
CXXFLAGS=$(CFLAGS)
PROGS=kbtree_test khash_keith khash_keith2 khash_test klist_test kseq_test kseq_bench \
kseq_bench2 ksort_test ksort_test-stl kvec_test kmin_test kstring_bench kstring_bench2 kstring_test \
kseq_bench2 ksort_test ksort_test-stl kvec_test kmin_test knetfile_test kstring_bench kstring_bench2 kstring_test \
kthread_test2

all:$(PROGS)
Expand Down Expand Up @@ -47,6 +47,9 @@ kvec_test:kvec_test.cc ../kvec.h
kmin_test:kmin_test.c ../kmath.h ../kmath.c
$(CC) $(CFLAGS) -o $@ kmin_test.c ../kmath.c

knetfile_test:../knetfile.h ../knetfile.c
$(CC) $(CFLAGS) -DKNETFILE_MAIN -o $@ ../knetfile.c

kstring_bench:kstring_bench.c ../kstring.h ../kstring.c
$(CC) $(CFLAGS) -o $@ kstring_bench.c ../kstring.c

Expand Down