Skip to content

Define AnnotationCallback to replace Nothing #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025

Conversation

blegat
Copy link
Contributor

@blegat blegat commented Jul 16, 2025

Passing nothing no longer works because of jump-dev/MathOptInterface.jl#2575.
Setting nothing is considered as unsetting something so after jump-dev/MathOptInterface.jl#2575, it no longer considers that MOI.set(sp.model, PricingCallback(), nothing) sets a pricing callback hence PricingCallback is not in the list of model attributes set and we don't pass the if statement in
https://github.com/jump-dev/MathOptInterface.jl/blob/d66c13dab9cbd76c3451faffafd7d828a4e04ee1/src/Utilities/cachingoptimizer.jl#L358-L369
I noticed this error when trying to run the pricing example of Coluna.

@rrsadykov
Copy link
Collaborator

Dear @blegat,

Thank you for your contribution!
Can you please merge the updated master branch to this PR.

@blegat blegat force-pushed the annotation_callback branch from c7964d2 to 33f355d Compare July 16, 2025 16:10
@blegat
Copy link
Contributor Author

blegat commented Jul 16, 2025

I have rebased it

@rrsadykov rrsadykov merged commit 6ad29a1 into atoptima:master Jul 16, 2025
2 checks passed
@odow
Copy link

odow commented Jul 17, 2025

I'll add BlockDecomposition to our tests so we don't break things in the future: jump-dev/MathOptInterface.jl#2785 I also added Coluna

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants