Fix term asserts #1717
Merged
Fix term asserts #1717
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memory.c had a missing semicolon, get/put_tuple_element in term.h unpacked header directly instead of using function. Additionally, first condition is already checked by term_is_tuple(). There's one unfixed assert TERM_DEBUG_ASSERT((t & 0x3) == 0x2); but fixing it would create conflicts with atomvm#1701 (changes magic values to macros). Signed-off-by: Jakub Gonet <jakub.gonet@swmansion.com>
bettio
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
memory.chad a missing semicolon,get/put_tuple_elementinterm.hunpacked header directly instead of using function. Additionally, first condition is already checked by term_is_tuple().There's one unfixed assert
TERM_DEBUG_ASSERT((t & 0x3) == 0x2);but fixing it would create conflicts with #1701 (changes magic values to macros).
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later