Add support for atoms longer than 255 bytes (but less than 256 chars) #1586
+934
−1,125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pguyot
force-pushed
the
w11/optimize-atoms
branch
5 times, most recently
from
2f3c4e9 to
ec78e91
Compare
pguyot
force-pushed
the
w11/optimize-atoms
branch
5 times, most recently
from
833adb7 to
7eeab10
Compare
pguyot
force-pushed
the
w11/optimize-atoms
branch
from
7eeab10 to
f019778
Compare
|
CI is broken with 32 bits. |
pguyot
force-pushed
the
w11/optimize-atoms
branch
3 times, most recently
from
314d282 to
ef806cb
Compare
Last issue is fixed in #1634 |
pguyot
force-pushed
the
w11/optimize-atoms
branch
from
ef806cb to
88abd1a
Compare
pguyot
force-pushed
the
w11/optimize-atoms
branch
4 times, most recently
from
824fa1a to
0e5d7f0
Compare
bettio
requested changes
Jul 1, 2025
Signed-off-by: Paul Guyot <pguyot@kallisys.net>
Signed-off-by: Paul Guyot <pguyot@kallisys.net>
Signed-off-by: Paul Guyot <pguyot@kallisys.net>
`atom_index_t` type represents a valid atom index. Signature of functions that returned an atom index that could be an error were modified consequently, introducing a type for the error results of `atom_table_ensure_atoms` and `atom_table_ensure_atom` and removing now redundant `globalcontext_insert_atom` in favor of `globalcontext_make_atom` that returns a term. Signed-off-by: Paul Guyot <pguyot@kallisys.net>
Update signature of `atom_write_mfa` so it takes atom length and data separately to prepare for longer atoms. Signed-off-by: Paul Guyot <pguyot@kallisys.net>
Change signature of `globalcontext_get_module` to get an `atom_index_t` to refer to a given module. Signed-off-by: Paul Guyot <pguyot@kallisys.net>
Update atom_table API so it uses pointers to characters with a length, and reduce further usage of AtomString which represent shorter atoms Signed-off-by: Paul Guyot <pguyot@kallisys.net>
pguyot
force-pushed
the
w11/optimize-atoms
branch
from
0e5d7f0 to
f260b37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also optimize storage and computation of atoms here and there.
Also fix hash of atom table (last character wasn't hashed).
See #1536
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later