Fix Erlang and Elixir archive CMakeModules #1510
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UncleGrumpy
changed the title
UncleGrumpy
force-pushed
the
fix_cmakemodules
branch
2 times, most recently
from
50cf8c1 to
59250fb
Compare
There were typos in both CMakeModules BuildErlang.cmake and BuildElixir.cmake that possibly lead to incorrect output names, especially when stacktrace lines are included. Signed-off-by: Winford <winford@object.stream>
UncleGrumpy
force-pushed
the
fix_cmakemodules
branch
from
59250fb to
e10b9cc
Compare
|
This was completely unnecessary. I was attempting to help sort out a problem in PR #1429, and thought there was a problem with these files, but this was not the cause of the problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were typos in both CMakeModules BuildErlang.cmake and BuildElixir.cmake that possibly lead to input modules not being found, especially when stacktrace lines are included.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later