This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Have enabling/disabling debugging not require restarting Atom #361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
When the debug function is disabled, it create a
() => {}
function to swallow logging. However, if the debug flag is switched on, the saved log properties retain the empty function and don't start logging until Atom is restarted.Likewise, when the debugging is disabled keeps the debug versions of the code and they continue to operate.
In addition,
localStorage.debug
needed to be set for debugging to work. Since we have a configuration values, the change inserts the required local storage keys for useful debug operations.Alternate Designs
Using the current implementation works, it just requires extra steps.
Benefits
Enabling and disabling debug should control the logging immediately, this makes it a less effort and easier to work with.
Possible Drawbacks
The handle the wrapped version of the logger requires extra complexity. There might be some edge cases and it will have a small impact on startup time to load the additional module.
Applicable Issues