Add `Model\UnionModel` model #677

georgehristov · 2020-07-26T21:41:49Z

No description provided.

src/Model/Aggregate.php

src/Model/Union.php

tests/Model/Client.php

tests/Model/Transaction.php

docs/unions.rst

DarkSide666 · 2024-03-17T13:17:46Z

docs/unions.md

+$unionPaymentInvoice->addField('type');
+```
+
+A new field "type" has been added that will be defined as a static constant.


What is "static constant" here? Minimal example would be good.

DarkSide666

I didn't review codebase, but in documentation there are some errors to fix.

mvorisek

prevent accidental merge

impl. is still probably problematic and tests should be cleaned up

mvorisek · 2024-05-04T13:56:16Z

src/Model/UnionModel.php

+    private function createUnionQuery(array $subqueries): Persistence\Sql\Query
+    {
+        $unionQuery = $this->getPersistence()->dsql();
+        $unionQuery->mode = 'union_all';


subqueries must support order by, limit or double wrap then to workaround

mvorisek · 2025-09-12T08:59:40Z

tests/ModelUnionTest.php

+        $transaction = $this->createTransaction();
+
+        $this->assertSameSql(
+            'select `name` `name` from `invoice` UNION ALL select `name` `name` from `payment`',


1) Atk4\Data\Tests\Persistence\Sql\MaterializedArrayActionTest::testRenderMultipleRows Atk4\Data\Persistence\Sql\ExecuteException: An exception occurred while executing a query: ORA-01790: expression must have same datatype as corresponding expression query: 'select true "bool", -9223372036854775808 "int", -1.5E - 50 "float", '' "string" from "DUAL" union all select NULL, 9223372036854775807, 1.0123456789123E + 300, ' foo ' from "DUAL"'

The ORA-01790 Oracle error is caused when one select selects null from untyped table.

georgehristov force-pushed the feature/introduce-aggregate-union-models branch from 3995cc8 to e545879 Compare July 26, 2020 21:46

[update] migrate aggregate and union models to data package

7083cf5

georgehristov force-pushed the feature/introduce-aggregate-union-models branch 3 times, most recently from 3827e56 to 189782c Compare July 27, 2020 06:37

georgehristov added 2 commits July 27, 2020 08:56

[update] combine union test in single class

9f95593

[fix] create db tables with all columns

691d9bd

georgehristov force-pushed the feature/introduce-aggregate-union-models branch from 189782c to 691d9bd Compare July 27, 2020 07:13

georgehristov closed this Jul 27, 2020

georgehristov reopened this Jul 27, 2020

georgehristov marked this pull request as ready for review July 27, 2020 09:10

[update] migrate and update docs

ee88bb5

georgehristov force-pushed the feature/introduce-aggregate-union-models branch from 4c75866 to ee88bb5 Compare July 27, 2020 09:22

georgehristov requested review from DarkSide666 and mvorisek July 27, 2020 11:11

georgehristov changed the title ~~Introduce aggregate and union models~~ Introduce Model\Aggregate and Model\Union models Jul 27, 2020