Feature/add kg key and privilege level support #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add optional kg_key field with hex validation (even length, max 40 chars) - Add privilege_level dropdown (ADMINISTRATOR/OPERATOR/USER) - Pass kg_key and privilege_level to both addon and RMCP fallback - Add translations for new fields (en, de, fr, el) - Fixes issue with mangled hex keys when using extra params field
|
@hatchmt Thanks for your contribution! Do you have a screenshot for the configuration screen? |
|
Yep, here ya go! 
|
|
I don't think I made this clear in the description, but these changes are dependent on my PR in the server addon. ateodorescu/home-assistant-addons#20 |
Yes, I know. Did you test this with an upgrade from an existing installation? I don't really have the time to test all of this at the moment. I don't want to merge both PRs and then existing installations to fail when upgrading. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a few problems while trying to get the IPMI connector working with my servers:
My servers use IPMIv2.0 authentication keys (referred to as Kg keys in the spec). The addon didn't have a field for that, so I had to try putting the hex key in the "extra params" field, which had a parsing error and would fail.
The user I was connecting with only had OPERATOR privileges. The addon did not have a means of specifying privileges and defaulted to ADMINISTRATOR (which is typically what we do NOT want to use as it can write raw values to the BMC, giving bad actors the chance to seriously impact systems)
To address those issues (and a few others I found along the way), I have made the following changes to the UI component:
I have these changes running in my personal Home Assistant environment. As far as I can tell, it's running without issues. Figured I'd send those changes back upstream in case anyone else is blocked by the same issues I was.