Allow role definition #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since you do not really need ADMIN permissions for this integration to work, one SHOULD use operator (if wanting to use power functions) or possible even USER if the goal is just to see the sensors. I have not tested the latter, so I might be wrong here.
If USER does not provide the needed permissions to view all the stats, we could remove it from the code.
If it does we could tell the user that having the USER permission is not enough to restart servers or not even present the user with the SWITCH option at all ? I am not deep enough into HA component programming to fix that issue though.
Hope this helps.
Further work:
Remove any mention of https://hub.docker.com/r/mneveroff/ipmi-server from the repo (for now) since their docker image is not on par with the features in the ipmi-server addon (see This repository is not feature par with ateodorescu/home-assistant-addons mneveroff/ipmi-server#5)Adjust https://github.com/ateodorescu/home-assistant-addons to accept a role parameter-> Allow role definition home-assistant-addons#18