Skip to content

Update routes.py #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update routes.py #2

wants to merge 1 commit into from

Conversation

atcreddy
Copy link
Owner

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 28, 2025
View reviewed changes
server/routes.py
@@ -13,7 +13,7 @@

if name:
cursor.execute(
dasdasd
"SELECT * FROM books WHERE name LIKE '%" + name + "%'"

Check failure

Code scanning / CodeQL

SQL query built from user-controlled sources High

This SQL query depends on a
user-provided value
Loading
.

Copilot Autofix

AI 4 months ago

To fix the problem, we need to use parameterized queries to safely embed user-provided data into the SQL query. This approach ensures that the database connector library handles the escaping and quoting of user input, preventing SQL injection attacks.

  • Replace the direct concatenation of the name parameter into the SQL query with a parameterized query.
  • Use placeholders in the SQL query and pass the user-provided values as parameters to the cursor.execute method.
Suggested changeset 1
server/routes.py

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/server/routes.py b/server/routes.py
--- a/server/routes.py
+++ b/server/routes.py
@@ -15,3 +15,3 @@
         cursor.execute(
-            "SELECT * FROM books WHERE name LIKE '%" + name + "%'"
+            "SELECT * FROM books WHERE name LIKE %s", ('%' + name + '%',)
         )
EOF
@@ -15,3 +15,3 @@
cursor.execute(
"SELECT * FROM books WHERE name LIKE '%" + name + "%'"
"SELECT * FROM books WHERE name LIKE %s", ('%' + name + '%',)
)
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@atcreddy