Skip to content

docs: add section about 0.4.8 breaking changes #3317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

ManonMarchand
Copy link
Member

@ManonMarchand ManonMarchand commented May 12, 2025

There still are ripples about version 0.4.8 breaking changes in SIMBAD's module. This PR document the major issues, in the hope to ease the transition

@aoberto : can you have a look? Edit: review is done, removing draft status

Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.87%. Comparing base (823e49f) to head (4ddb0aa).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3317      +/-   ##
==========================================
- Coverage   69.88%   69.87%   -0.01%     
==========================================
  Files         232      232              
  Lines       19761    19769       +8     
==========================================
+ Hits        13810    13814       +4     
- Misses       5951     5955       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ManonMarchand ManonMarchand marked this pull request as ready for review May 12, 2025 09:59
@ManonMarchand
Copy link
Member Author

Hi!
Do you think this section is a bad idea? Our motivation is to have a page to point to people asking questions in our support email, as we see that reading the changelog is sometimes challenging. Users often don't find which version had the major breaking changes.

Copy link
Contributor

@keflavich keflavich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good addition.

@bsipocz bsipocz added this to the v0.4.11 milestone May 19, 2025
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@bsipocz bsipocz merged commit 3368e5b into astropy:main May 19, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants