-
Notifications
You must be signed in to change notification settings - Fork 182
Binder dependencies #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binder dependencies #617
Conversation
I think this approach is fine and practical, but I wonder if we want a mechanism to automatically generate this top-level requirements file based on all of the individual tutorial requirements files? |
I guess then there will be ambiguous cases if there are disagreements in version requirements... I think I'm ok with this approach for now (even though there is duplicated information that we have to manually keep in sync) but let's make an issue with the aspirational goal of having a script to "build" the global requirements file automatically. |
After removing the global
requirements.txt
in #606, the Binder build broke because it expects that file. In general it expects a single requirements file for all notebooks (see here; for details of how to specify requirements, see here).This PR adds
binder/requirements.txt
to the top-level directory, which Binder uses to successfully build. This single requirements file currently works for all notebooks. If in the future individual notebooks need packages installed with versions that differ from those inbinder/requirements.txt
, execution of those notebooks in Binder will fail.PR also updates text in the README.
Closes #615
Closes #616
Closes #535