Skip to content

Unpin pyvo dep #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Unpin pyvo dep #603

merged 1 commit into from
Sep 24, 2024

Conversation

jeffjennings
Copy link
Member

@jeffjennings jeffjennings commented Sep 24, 2024

@adrn

This PR removes a pin on the pyvo dependency.

The dependency is currently pinned to pyvo==1.2.0. This is causing several notebook executions to fail because of a call to the deprecated from astropy.utils.decorators import wraps from within pyvo 1.2.0. From version 1.2.1 onward, pyvo instead uses from functools import partial, wraps (pyvo changelog).

Unpinning 1.2.0 may break something else, but there's no comment in requirements.txt as to why it's pinned, so this is a first step to get the notebooks to execute.

  • Check the box to confirm that you are familiar with the contributing guidelines and/or indicate (check the box) that you are familiar with our contributing workflow.
  • Confirm that any contributed tutorials contain a complete Introduction which includes an Author list, Learning Goals, Keywords, Companion Content (if applicable), and a Summary.
  • Check the box to confirm that you are familiar with the Astropy community code of conduct and you agree to follow the CoC.

@adrn adrn merged commit 306f81f into astropy-learn:main Sep 24, 2024
3 checks passed
@jeffjennings jeffjennings deleted the pyvo_dep branch September 24, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants