Skip to content

Break up long-running query in DR1 notebook #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

weaverba137
Copy link
Member

This PR fixes #270.

The compound query is split up into an inner query which can run asynchronously with the intermediate results stored in MyDB.

Although a solution involving lastnight from desi_dr1.ztile would be possible in principle, the plots resulting from this query expect MJD, and I didn't feel like doing a lot of extra math to convert lastnight (YYYYMMDD) into a day number like MJD.

@weaverba137 weaverba137 self-assigned this Apr 24, 2025
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@weaverba137
Copy link
Member Author

@stephjuneau, @jacquesalice, this PR seems to have been forgotten. Could you please take a look?

Copy link
Member

@jacquesalice jacquesalice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weaverba137 thanks for the reminder!

I ran this notebook on gp13. The long-running query did finish successfully for me, but it took 21 minutes to complete. And at the "Retrieving results" part of the async_ run, I got this message from Jupyter Lab:

IOPub data rate exceeded.
The Jupyter server will temporarily stop sending output
to the client in order to avoid crashing it.
To change this limit, set the config variable
`--ServerApp.iopub_data_rate_limit`.

Current values:
ServerApp.iopub_data_rate_limit=50000000.0 (bytes[/sec](https://gp13.datalab.noirlab.edu/sec))
ServerApp.rate_limit_window=5.0 (secs)

...Not sure if this is a red flag or if it's fine?

@weaverba137
Copy link
Member Author

I've seen the warning message before, and it is just a warning. I think configuration of the Jupyter Lab server would need to be changed to get rid of it.

@jacquesalice
Copy link
Member

Can I merge this? Or @stephjuneau did you still want to review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize long query from How_to_query_DESI_DR1_Data.ipynb
2 participants